dash: Make the show apps button insensitive when we're dragging a non-favorite

This doesn't handle the tooltip case, unfortunately. That will come in a bit.

https://bugzilla.gnome.org/show_bug.cgi?id=685313

diff --git a/js/ui/dash.js b/js/ui/dash.js
index 047588d440243fd78ef14e219fb8deb49e612794..3a7828cf8dd31d63373ea064a5a48d4d69330446 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -285,8 +285,16 @@ const ShowAppsIcon = new Lang.Class({
             this.setLabelText(_("Show Applications"));
     },
 
-    // Rely on the dragged item being a favorite
     handleDragOver: function(source, actor, x, y, time) {
+        let app = getAppFromSource(source);
+        if (app == null)
+            return DND.DragMotionResult.NO_DROP;
+
+        let id = app.get_id();
+        let isFavorite = AppFavorites.getAppFavorites().isFavorite(id);
+        if (!isFavorite)
+            return DND.DragMotionResult.NO_DROP;
+
         return DND.DragMotionResult.MOVE_DROP;
     },